On Tue, Sep 18, 2012 at 12:47:36PM -0700, Junio C Hamano wrote: > >> Jeff King <peff@xxxxxxxx> writes: > >> > >> > But even without that, I still think format-patch is a reasonable time > >> > to do it. It is the time when I proof-read my commit message and patch > >> > in its final form, and think "do I really want to send this?". > >> > >> But it is not like "I cannot sign off because I think it is still > >> iffy". > > > > No, that is not the particular reason in my case, but I think I > > explained other reasons why "format-patch -s" is not a wrong workflow. > > Then I didn't read it. What does "do I really want to send this?" > have anything to do with DCO in any case? Because it is an excellent time to think about "am I willing and able to agree to the DCO?" As I said, for me personally working on git.git, that is not generally an issue. But I think it is perfectly reasonable for somebody to work and commit in isolation, and then only decide on the DCO during the sending phase (perhaps because they need to clear it with their company's legal department or some such). In other words, "it is iffy at the time of commit" might be exactly the reason for some people. If you are responding to my "that is not the particular reason in my case", I will paraphrase the reason I gave earlier: I find it annoying and pointless to type "-s" on every commit. We do not have commit.signoff, but we do have format.signoff. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html