Re: [PATCH] rebase -i: fix misleading error message after 'exec no-such' instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 9/18/2012 13:20, schrieb Matthieu Moy:
> Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:
> 
>> From: Johannes Sixt <j6t@xxxxxxxx>
>>
>> When the todo sheet of interactive rebase instructs to run a non-existing
>> command, the operation stops with the following error:
>>
>>   Execution failed: no-such
>>   You can fix the problem, and then run
>>
>>           git rebase --continue
>>
>>   fatal: 'rebase' appears to be a git command, but we were not
>>   able to execute it. Maybe git-rebase is broken?
> 
> While you're there, maybe you want to turn the first line into
> 
> Execution failed: no-such (command not found)

No, I don't want to: Neither do we have errno here, nor can we be specific
enough because the whole shell script the user gave after 'exec' is
repeated here.

I would rather remove the line so that it does not distract from the more
specific error message that the shell gave. On top of that, the command is
already dumped before it is executed; we don't need to repeat it.

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]