Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
> All users of $gs->{path} should have been converted to use the
> accessor by now. Check our work by renaming the underlying variable
> to break callers that try to use it directly.
>
> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
> ---
I like this ;-) If we know we have good coverage, this would be a
sensible way to catch remaining code that hasn't been converted.
> perl/Git/SVN.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
> index 3aa20109..33f15682 100644
> --- a/perl/Git/SVN.pm
> +++ b/perl/Git/SVN.pm
> @@ -2293,11 +2293,11 @@ sub path {
>
> if (@_) {
> my $path = shift;
> - $self->{path} = $path;
> + $self->{_path} = $path;
> return;
> }
>
> - return $self->{path};
> + return $self->{_path};
> }
>
> # for read-only access of old .rev_db formats
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html