Re: [PATCH/RFC] test-lib: add support for colors without tput

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 14.09.2012 19:28, schrieb Johannes Sixt:
> Am 14.09.2012 18:58, schrieb Erik Faye-Lund:
>>  	tput () {
>>  		case "$1" in
>>  		bold)
>> -			echo -ne "\033[1m" ;;
>> +			printf "\033[1m" ;;
>>  		setaf)
>> -			echo -ne "\033[0;3$2m" ;;
>> +			printf "\033[0;3$2m" ;;
> 
> This should be
> 			printf '\033[0;3%sm' "$2" ;;
> 
>>  		sgr0)
>> -			echo -ne "\033(\033[m" ;;
>> +			printf "\033(\033[m" ;;
>>  		esac
>>  	}
>>  fi
> 
> Did you test this only in rxvt or in CMD as well? (I hadn't time to
> test, yet, so I'm asking :-)

I tested your patch with this fixup, and it works for me (in CMD).

-- Hannes

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]