Given the git project policy that *.c files that include header files are responsible for including everything the headers they include need, there is no need for fetch-pack.h to include string-list.h itself. As for the files that include fetch-pack.h: * builtin/clone.c and builtin/fetch-pack.c include builtin.h which includes notes.h which includes string-list.h * transport.c includes string-list.h so no other adjustments are needed. Suggested by: Junio C Hamano <gitster@xxxxxxxxx> Signed-off-by: Michael Haggerty <mhagger@xxxxxxxxxxxx> --- fetch-pack.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fetch-pack.h b/fetch-pack.h index cb14871..018f35f 100644 --- a/fetch-pack.h +++ b/fetch-pack.h @@ -1,8 +1,6 @@ #ifndef FETCH_PACK_H #define FETCH_PACK_H -#include "string-list.h" - struct fetch_pack_args { const char *uploadpack; int unpacklimit; -- 1.7.11.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html