On Fri, Sep 14, 2012 at 7:12 PM, Elia Pinto <gitter.spiros@xxxxxxxxx> wrote: > 2012/9/14 Elia Pinto <gitter.spiros@xxxxxxxxx>: >> 2012/9/14 Erik Faye-Lund <kusmabite@xxxxxxxxx>: >>> On Fri, Sep 14, 2012 at 6:54 PM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: >>>> On Fri, Sep 14, 2012 at 6:41 PM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: >>>>> diff --git a/t/test-lib.sh b/t/test-lib.sh >>>>> index 78c4286..7d1b34b 100644 >>>>> --- a/t/test-lib.sh >>>>> +++ b/t/test-lib.sh >>>>> @@ -129,6 +129,20 @@ export _x05 _x40 _z40 LF >>>>> # This test checks if command xyzzy does the right thing... >>>>> # ' >>>>> # . ./test-lib.sh >>>>> + >> Nice. But this setting should be check that we have a terminal first isn't ? >> Some test like this before >> >> test "X$$TERM" != Xdumb \ >> && test -t 1 2>/dev/null \ >> && .... > and in reality this echo use is not portable. Yeah; I posted a couple of follow-up mails earlier where I had noticed it and changed to printf instead. It seems the testsuite is already using it, so it's probably portable. Thanks a lot for the extra set of eyes :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html