Should I interpret the silence as "I don't care, if you want it, go for it" or "not acceptable, but no reasons given"? I'd like some form of it in. Reverting the i18n diffstat patch is the last resort that I really don't want to do. On Sun, Aug 26, 2012 at 2:26 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > The l10n effort leads to a situation where a contributor can submit a > patch with some auto-generated information in his language, which may > not be the team's language. We need to make sure exchange medium like > patch is always in a common language that the team understands. > > Now this team language may not necessarily be English. However there > are technical difficulties involved in switching between two > languages. The only way I can think of, on top of gettext, is provide > git translations in multiple domains. Say diff machinery uses > "git-diff" domain while the rest is in "git". We can drive gettext to > use language X for diff machinery, and Y for the rest. For that, we > replace gettext() with dgettext(). > > It's cumbersome. And there has not been any sign that there will be > a real user for it. So I assume that the "team language" will always > be English. It's simpler and should cover 90% of the user base. If > someday people ask for that, supporting it is simply a matter of > rewriting C_() and CQ_() macros in the first patch to use dgettext() > instead. > > Switching between a language and English is easier. We just need an > if/else to decide whether to call gettext(). Which is what the first > patch does, just for certain parts of diff machinery. Error messages > will alway be in native language. > > The second patch puts format-patch output in English unconditionally. > Again I'm partly lazy and not so sure that there will be needs for > format-patch to produce in native language. If someone needs it, we > can introduce a new config key that flip no_l10n flag back to 0. > > More commands may follow format-patch. I think that 'apply' should also > use English for non-tty output, unless users request it to be in local > language. IOW local language is treated pretty much like coloring. > > Nguyễn Thái Ngọc Duy (2): > Allow to print diffstat in English regardless current locale > format-patch: always print diffstat in English > > builtin/apply.c | 2 +- > builtin/log.c | 1 + > diff.c | 19 ++++++++++++------- > diff.h | 3 ++- > 4 files changed, 16 insertions(+), 9 deletions(-) > > -- > 1.7.12.rc1.27.g6d3049b.dirty > -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html