Adam Spiers <git@xxxxxxxxxxxxxx> writes: > On Sun, Sep 2, 2012 at 9:35 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> * avoid unnnecessary braces {} around single statement blocks, e.g. >> >> -if (exclude) { >> +if (exclude) >> return exclude; >> -} >> >> * else should follow close brace '}' of if clause, e.g. >> >> if (...) { >> ... >> -} >> -else { >> +} else { >> ... > > What about when the if clause requires braces but the else clause > doesn't? Should it be > > if (...) { > ...; > ...; > } else > ...; > > or > > if (...) { > ...; > ...; > } > else > ...; > > ? Neither. We try to do (but often fail ;-) if (...) { ...; ...; } else { ...; } following the kernel style, unless there is good reason not to. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html