On Thu, Sep 6, 2012 at 10:21 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes: > >> We could introduce exclude_path() and kill path_excluded() then. There >> are just about 5-6 call sites to replace. > > The name path_excluded(... path ...) sounds like it is asking a > yes/no question "is this path excluded?", which actually is what is > going on. > > The name exclude_path(... path ...) sounds as if you are requesting > somebody to exclude the path. Does that meaning match the semantics > of the function? I'm not great at naming. And path_excluded() cannot be reused to avoid problems with other ongoing series if any. So path_is_excluded()? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html