Junio C Hamano <junkio@xxxxxxx> wrote: > Also the patch makes the maximum mapped from (1<<26) bytes to > 256MB which is four-fold; I think tweaking such settings should > be done as a separate step. Sure, I don't have any objection to that, but I'm also not going to write a patch to drop it back down to 128 MiB. The old code was somewhat flawed. It did not always honor the upper limit of PACK_MAX. For example it always overshoots that limit anytime we have a packfile larger than PACK_MAX. The only way you will hit the new 256 MiB limit is if you actually have a packfile (or a set of packfiles) that large. If that is the case then you were probably overshooting PACK_MAX before. With this series you will never overshoot core.packedGitLimit (256 MiB), no matter how big your packfiles are. So the new 256 MiB limit, although a four-fold increase, is actually smaller virtual memory footprint for those users who may have been hitting PACK_MAX before. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html