RE: Porting git to HP NonStop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Junio C Hamano [mailto:gitster@xxxxxxxxx]
> Sent: Wednesday, August 22, 2012 10:50 PM
> To: Joachim Schmitz
> Cc: git@xxxxxxxxxxxxxxx; rsbecker@xxxxxxxxxxxxx
> Subject: Re: Porting git to HP NonStop
> 
> "Joachim Schmitz" <jojo@xxxxxxxxxxxxxxxxxx> writes:
> 
> > Hi folks
> >
> > There another API missing on HP NonStop and that is setitimer(), used
> > in progress.c and build/log.c I do have a homebrewed implementation, on
top
> of alarm(), it goes like this:
> >
> > #include "../git-compat-util.h"
> > #undef getitimer
> > #undef setitimer
> >
> >
> > int
> > git_getitimer(int which, struct itimerval *value)
> 
> See Documentation/CodingGuidelines for style nits.

Will do and adjust code accordingly. Here I was more concerned about content
though ;-)

...
> > Worth being added to compat/, e.g. as setitimer.c, or, as itimer.c (as
> > a by-product, it has getitimer() too)?
> 
> If it helps your port, compat/itimer.c sounds like a good place.
> Doesn't it need a new header file to introduce structures and constants,
too?

You mean the ITIMER_* and struct itimerval, right?
On NonStop these are available in <sys/time.h>, so here's no need to add
them.

Bye, Jojo

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]