Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Florian Achleitner <florian.achleitner.2.6.31@xxxxxxxxx> writes:

> On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
>> Junio C Hamano <gitster@xxxxxxxxx> writes:
>> > I think you meant something like:
>> > 
>> >       init_notes(NULL, notes_ref, NULL, 0);
>> >
>> >         marksfile = fopen(marksfilename, "r");
>> >         if (!marksfile) {
>> >               regenerate_marks(marksfilename);
>> >                 marksfile = fopen(marksfilename, "r");
>
> Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.

Please fix up things like that in your reroll.  I was doing minimum
fixes I noticed to get it compile before pushing it out as part of
'pu' (the alternative was simply not to merge and discard the
topic).

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]