Re: [PATCH/RFC v4 01/16] GSOC remote-svn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote:
> That indicates that one necessary patch to add logic to Makefile to
> go and build that subdirectory, at least before running the test,
> but possibly as part of the "all" target, is missing, isn't it?
> 
> Or you can add, at the beginning of your tests files that require
> the contrib bit, to have something like
> 
>         if test -e "$GIT_BUILD_DIR/remote-svn"
>         then
>                 test_set_prereq REMOTE_SVN
>         fi
> 
> and protect your tests with the prerequisite, e.g.
> 
>         test_expect_success REMOTE_SVN 'test svn:// URL' '
>                 ...
>         '
> 
> without changing the top-level Makefile.

What version would you prefer? Currently nothing in contrib/ is built by the 
toplevel Makefile..
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]