On Sunday 19 August 2012 04:37:35 David Michael Barr wrote: > On Sat, Aug 18, 2012 at 6:40 AM, Florian Achleitner > > <florian.achleitner.2.6.31@xxxxxxxxx> wrote: > > Hi! > > > > This patch series should prepare vcs-svn/svndump.* for branch > > detection. When starting with this feature I found that the existing > > functions are not yet appropriate for that. > > These rewrites the node handling part of svndump.c, it is very > > invasive. The logic in handle_node is not simple, I hope that I > > understood every case the existing code tries to adress. > > At least it doesn't break an existing testcase. > > > > The series applies on top of: > > [PATCH/RFC v4 16/16] Add a test script for remote-svn. > > I could also rebase it onto master if you think it makes sense. > > > > Florian > > > > [RFC 1/5] vcs-svn: Add sha1 calculaton to fast_export and > > This change makes me uncomfortable. > We are doubling up on hashing with fast-import. > This introduces git-specific logic into vcs-svn. You might need to read the rest of the series to see why I did this. Short version: For fast-import, I seperated sending data from the commits, it is sent using the 'blob' command. You have two choices of referencing that blobs later, by using a mark, or by giving their sha1. Marks are already used for marking commits, and there is only one "mark namespace". So I couldn't use marks to reference the blobs in a nice way. This allows for referencing them by their sha1. > > > [RFC 2/5] svndump: move struct definitions to .h. > > [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling > > [RFC 4/5] vcs-svn/svndump: rewrite handle_node(), > > [RFC 5/5] vcs-svn: remove repo_tree > > I haven't read the rest of the series yet but I expect > it is less controversial than the first patch. Hm.. I'm not sure ;) > > -- > David Michael Barr Florian -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html