Junio C Hamano <gitster@xxxxxxxxx> writes:
> Florian Achleitner <florian.achleitner.2.6.31@xxxxxxxxx> writes:
>
>> On Friday 17 August 2012 21:16:59 Junio C Hamano wrote:
>>> Comments from mentors and people interested in remote helpers?
>>>
>>> I did minimum line wrapping, typofix and small compilation fixes
>>> and queued these on 'pu'; I think I saw one commit whose message
>>> I didn't quite get what it was trying to say, and another that was
>>> missing S-o-b (I left them untouched).
>>
>> Should I provide a better version? I found the commit that I forgot to sign-
>> off, but I'm not sure which message you mean.
>
> There was a one with "E.g:" followed by an incomplete sentence that
> did not parse for me. Can you fetch 'pu', run format-patch on your
> topic and compare the output with what you sent to the list?
Just to show how, here is what I did just now.
(0) Store your 16-patch series and 5-patch series in a mbox;
(1) Check where the tip of fa/vcs-svn topic is at.
$ git log --oneline --first-parent master..pu | grep fa/
2ce959b Merge branch 'fa/vcs-svn' into pu
574ffe1 Merge branch 'fa/remote-svn' into pu
(2) Check where the topic was based on.
$ git log --oneline --first-parent master..2ce959b^2
...
1385a48 Implement a remote helper for svn in C
(3) Detach at the same base and apply the mbox from step (0).
$ git checkout 1385a48^
$ git am --whitespace=nowarn mbox
(4) Format them (i.e. as the way you sent them, without my fixup)
$ git format-patch --stdout master >./+fa-0
(5) Format with my fixup
$ git format-patch --stdout master..2ce959b^2 >./+fa-1
(6) Compare them. The differences are my fixups.
$ diff -u ./+fa-0 ./+fa-1 | less
Patch #17 "vcs-svn: Add sha1 calculation to fast_export ..." was the
one with a sentence whose purpose was unclear to me.
By the time you see this message, the tip of "pu" may have been
updated with further updates, so please do not trust 2ce959b above.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html