Junio C Hamano <gitster <at> pobox.com> writes: > > Jiang Xin <worldhello.net <at> gmail.com> writes: > > > Run command 'git rev-parse --git-dir' under subdir will return realpath > > of '.git' directory. Some test scripts compare this realpath against > > "$TRASH_DIRECTORY", they are not equal if current working directory is > > on a symlink. > > > > In this fix, get realpath of "$TRASH_DIRECTORY", store it in > > "$TRASH_REALPATH" variable, and use it when necessary. > > I wonder if running test in a real directory (in other words, "fix" > your cwd) may be a simpler, more robust and generally a better > solution, e.g. something silly like... > > diff --git a/t/test-lib.sh b/t/test-lib.sh > index acda33d..7f6fb0a 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -15,6 +15,8 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see http://www.gnu.org/licenses/ . > > +cd "$(pwd -P)" > + > # if --tee was passed, write the output not only to the terminal, but > # additionally to the file test-results/$BASENAME.out, too. > case "$GIT_TEST_TEE_STARTED, $* " in What is the status of this bug? Today I wasted a bunch of time trying to track down a build breakage that was ultimately caused by this problem. I was running the test suite on master with "--root=/dev/shm" (my usual setting), but this caused tests t4035 and t9903 to fail as described upthread. (It turns out that on my system, /dev/shm is a symlink to /run/shm.) For me, the failure is fixed by Jiang Xin's patch, but it is not fixed by Junio's. In the case of t4035 in failing test "git diff --ignore-all-space, both files outside repo", right before "git diff" is called, PWD=/run/shm/trash directory.t4035-diff-quiet/test-outside/non/git GIT_CEILING_DIRECTORIES=/dev/shm/trash directory.t4035-diff-quiet/test-outside I can work around the problem by using "--root=/run/shm". But it would be good to get this problem fixed one way or the other to spare other people the same pain. Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html