Jeff King <peff@xxxxxxxx> writes:
> On Mon, Aug 13, 2012 at 12:07:35PM -0700, Junio C Hamano wrote:
>
>> * And this is your 4 adjusted for the previous one, releaving the
>> caller from having to figure out where the capability string
>> ends.
>> [...]
>> @@ -829,8 +831,15 @@ static struct ref *do_fetch_pack(int fd[2],
>> fprintf(stderr, "Server supports ofs-delta\n");
>> } else
>> prefer_ofs_delta = 0;
>> - if (server_supports("agent"))
>> +
>> + if ((agent_feature = server_feature("agent", &agent_len)) != NULL &&
>> + 5 < agent_len && agent_feature[5] == '=') {
>> agent_supported = 1;
>> + if (args.verbose) {
>> + fprintf(stderr, "Server version is %.*s\n",
>> + agent_len - 6, agent_feature + 6);
>> + }
>> + }
>
> Yeah, this is exactly the kind of ugliness I was trying to avoid with my
> allocating wrapper. Still, there is only one call site, so I do not care
> overly much (and I as I've already said, I'm lukewarm on the final two
> patches, anyway).
Actually, the above is vastly superiour compared to the allocating
kind. Be honest and think about it. If the caller wants to
allocate, it could, and it does not even have to count. If the
caller does not want to allocate, it does not have to pay the price.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html