Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert Luberda <robert@xxxxxxxxxx> wrote:
> Eric Wong wrote:
> >> +		echo "PATH=\"$PATH\"; export PATH" >> $hook
> >> +		echo "svnconf=\"$svnconf\"" >> $hook
> >> +		cat >> "$hook" <<- 'EOF2'
> >> +			cd work-auto-commits.svn
> >> +			svn up --config-dir "$svnconf"
> > 
> > That doesn't seem to interact well with users who depend on
> > svn_cmd pointing to something non-standard.  Not sure
> > what to do about it, though....

> I have no idea how to change it either. I've tried to source the
> lib-git-svn.sh file inside the hook, but it sources test-lib.sh, and the
> latter script doesn't work well if it is sourced by non-test script.
> Anyway I the part of my original patch unchanged.

Ah, so svn_cmd only cares about --config-dir and you already handled
that :)   I misremembered it also allowed for non-standard SVN
installations :x

I've pushed your updated patch to my "maint" branch on
git://bogomips.org/git-svn since "master" has larger pending changes.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]