Re: [PATCH 09/16] Read index-v5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



General note. I wonder if we should create a separate source file for
v5 (at least the low level handling part). Partial reading/writing
will come (hopefully soon) and read-cache.c on master is already close
to 2000 lines.

On Thu, Aug 2, 2012 at 6:01 PM, Thomas Gummerer <t.gummerer@xxxxxxxxx> wrote:
> +static struct cache_entry *cache_entry_from_ondisk_v5(struct ondisk_cache_entry_v5 *ondisk,
> +                                                  struct directory_entry *de,
> +                                                  char *name,
> +                                                  size_t len,
> +                                                  size_t prefix_len)
> +{
> +       struct cache_entry *ce = xmalloc(cache_entry_size(len + de->de_pathlen));
> +       int flags;
> +
> +       flags = ntoh_s(ondisk->flags);

huh? ntoh_s (and ntoh_l below)? search/replace problem?

> +       ce->ce_ctime.sec  = 0;
> +       ce->ce_mtime.sec  = ntoh_l(ondisk->mtime.sec);
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]