Re: [PATCH/RFC] grep: add a perlRegexp configuration option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 31, 2012 at 2:04 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Turning "grep.extendedregexp" from boolean to an extended boolean to
> allow "grep.extendedregexp = perl" might be a better alternative.
> That way, the user wouldn't have to worry about 7 variants of
> grep.fooRegexp variables twenty years down the road, even though the
> set of possible values given to "grep.extendedregexp" may have grown
> over time by then.

Yeah, that sounds good. I've re-written the patch to accommodate the
change allowing for the current boolean settings of true/false as well
as "perl". For the sake of completeness (verbosity? pedantry?) I also
included a setting for "extended" which is equivalent to true.

With this sort of change, would a more generic "grep.regexpMode",
"grep.patternType" or something similar perhaps be more descriptive,
with "grep.extendedRegexp" being aliased for backwards compatibility
purposes? I could also add that functionality if desired.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]