On Tue, Jul 31, 2012 at 8:37 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > + /* Avoid iconv_open()/iconv_close() if there is nothing to convert */ > + for (i = 0; i < argc; i++) { > + if (has_utf8(argv[i], (size_t)-1, NULL)) > + break; > + } > + if (argc <= i) > + return; /* no utf8 found */ sorry, but "argc" can never be smaller than "i", right? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html