Junio C Hamano <gitster@xxxxxxxxx> writes: > In practice, the majority of paths do not have any utf8 character > that needs the canonicalization. Lazily call iconv_open() and > iconv_close() to avoid unnecessary overhead. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > > * This is not even compile tested, so it needs testing and > benchmarking, as I do not even know how costly the calls to > open/close are when we do not have to call iconv() itself. > > This was brought up by Linus (Cc'ed) in http://goo.gl/INWVc Even though I also think that per-DIR iconv may not be the optimal way to organize this (I think iconv_t should be a per-thread thing at most), it would be a more involved change that needs to be done by somebody who actually works on Mac, so the patch I sent is kept deliberately minimum. Just FYI. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html