Junio C Hamano wrote: > "Michael G. Schwern" <schwern@xxxxxxxxx> writes: >> Also it can compile on its own now, yay! > > Hmmm. I agree with Michael's "yay" and also think it's fine that after patch 3 it isn't there yet. That's because git-svn.perl doesn't use Git::SVN on its own but helps it out a little. So even if we only applied patches 1-3, git-svn would still work (maybe it's worth testing "perl -MGit::SVN" by hand to avoid the "it's doubtful" about whether Git::SVN is self-contained and replace it with a more certain statement?), and patch 4 just makes it even better. [...] > In short: > > - I didn't see anything questionable in 1/4; > > - Calling up ::opt_prefix() from module in 2/4 looked ugly to me > but I suspect it should be easy to fix; > > - 3/4 was a straight move and I didn't see anything questionable in > it, but I think it would be nicer if intermediate steps can be > made to still work by making 4/4 come first or something > similarly simple. > > If the issues in 2/4 and 3/4 are easily fixable by going the route I > handwaved above, the result of doing so based on this round is ready > to be applied, I think. > > Eric, Jonathan, what do you think? I think this is pretty good already, though I also like your suggestion re 2/4. I haven't reviewed the tests these introduce and assume Eric has that covered. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html