David Aguilar <davvid@xxxxxxxxx> writes: > On Thu, Jul 26, 2012 at 4:31 AM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: >> On Wed, Jul 25, 2012 at 5:14 AM, David Aguilar <davvid@xxxxxxxxx> wrote: >>> Symlinks are not ubiquitous on Windows so make --no-symlinks the default. >>> >>> Signed-off-by: David Aguilar <davvid@xxxxxxxxx> >>> --- >>> I don't have cygwin so I can't verify this one myself. >>> Is 'cygwin' really the value of $^O there? >>> >>> git-difftool.perl | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/git-difftool.perl b/git-difftool.perl >>> index 591ee75..10d3d97 100755 >>> --- a/git-difftool.perl >>> +++ b/git-difftool.perl >>> @@ -291,7 +291,8 @@ sub main >>> gui => undef, >>> help => undef, >>> prompt => undef, >>> - symlinks => $^O ne 'MSWin32' && $^O ne 'msys', >>> + symlinks => $^O ne 'cygwin' && >>> + $^O ne 'MSWin32' && $^O ne 'msys', >> >> I thought Cygwin supported (their own version of) symlinks? What's the >> rationale for not using it by default there? > > I am not a Cygwin user so I cannot verify whether it is a good or bad idea. > > I have a few questions regarding symlinks on Cygwin: > > Do the symlinks work consistently with the Perl symlink() function? > Can we always rely on this capability being available? > Do all win32 filesystems support it? > Do all builds of cygwin perl support it? > > If any of these answers are "no" or "maybe", then an improvement > beyond this patch would be to perhaps support a `difftool.symlinks` > configuration variable so that the user can tell us what to use as the > default. I would think it is an independent topic that can be used by people not on Windows. It is good to be conservative by disabling symlinks by default. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html