2012/7/26 Junio C Hamano <gitster@xxxxxxxxx>:
> After stating the observation like the above, please make it a habit
> to say "which is bad because...", if you think it is a bad behaviour
> and the patch is about fixing it.
Indead before I start, I examine git-commit and git-am, and find
the behaviours of the two commands are different.
"git commit -s" checks the last line of the footer, while "git -am"
checks the last S-o-b. E.g. original commit X:
commit log...
Signed-off-by: A
Signed-off-by: B
Reported-by: C
When user B amend the commit, the amended commit Y looks like:
commit log...
Signed-off-by: A
Signed-off-by: B
Reported-by: C
Signed-off-by: B
While if the original commit X send to user B by patch, and
user B run command "git am -s", the commit would be:
Signed-off-by: A
Signed-off-by: B
Reported-by: C
So I guess duplicate S-o-b is not intentional.
I use an alias for commit:
git config --global alias.ci "commit -s"
And will encounter duplicate S-o-b issues frequently, especially
format-patch/send-email workflow.
--
Jiang Xin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html