Martin von Zweigbergk wrote: > On Tue, Jul 24, 2012 at 11:27 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> Jiang Xin wrote: >>> Gettext message should not start with '-' nor '--'. Since the '-d' and >>> '--dotest' options do not exist in OPTIONS_SPEC variable, it's safe to >>> remove the block. >> >> The above justification is not a sufficient reason to stop giving >> helpful advice when someone uses an option that was historically >> supported: > > I think Jiang is saying that "git am --dotest=..." already errors out > because "dotest" is not in the OPTIONS_SPEC. See 98ef23b (git-am: > minor cleanups, 2009-01-28). Oh, I see now. I guess that means the intended justification is the following? The git am -d/--dotest option has errored out with a message since e72c7406 (am: remove support for -d .dotest, 2008-03-04). The error message about lack of support was eliminated along with other cleanups (probably by mistake) a year later by removing the option from the option table in 98ef23b3 (git-am: minor cleanups, 2009-01-28). But the code to handle -d and --dotest stayed around even though ever since then it could not be tripped. Remove this dead code. Noticed because the error message starts with a '-' and xgettext does not cope well with that. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html