Some grammatical nits about the commit message. I hope this doesn't
come across as too picky/annoying ... And you might want to wait for
a native to confirm whether these nits are actually all warranted.
On 07/24/2012 10:00 AM, Jiang Xin wrote:
> Run
>
s/Run/Running/
> command 'git rev-parse --git-dir' under subdir
>
s/under subdir/under a subdir/. Or even better IMHO,
s/under subdir/in a subdir/
> will return realpath
>
s/realpath/the realpath/
> of '.git' directory.
>
s/of/of the/
> Some test scripts compare this realpath against
> "$TRASH_DIRECTORY", they are not equal
>
s/they are not/but they are not/
> if current working directory is on a symlink.
>
s/current/the current/
> In this fix, get realpath
>
s/realpath/the realpath/
> of "$TRASH_DIRECTORY", store it in
> "$TRASH_REALPATH" variable, and use it when necessary.
>
> Signed-off-by: Jiang Xin <worldhello.net@xxxxxxxxx>
> ---
> t/t4035-diff-quiet.sh | 8 +++++---
> t/t9903-bash-prompt.sh | 13 +++++++------
> 2 个文件被修改，插入 12 行(+)，删除 9 行(-)
>
> diff --git a/t/t4035-diff-quiet.sh b/t/t4035-diff-quiet.sh
> index 23141..5855 100755
> --- a/t/t4035-diff-quiet.sh
> +++ b/t/t4035-diff-quiet.sh
> @@ -4,6 +4,8 @@ test_description='Return value of diffs'
>
> . ./test-lib.sh
>
> +TRASH_REALPATH="$(cd "$TRASH_DIRECTORY"; pwd -P)"
> +
BTW, the outer quotes are not needed; this is enough:
TRASH_REALPATH=$(cd "$TRASH_DIRECTORY"; pwd -P)
Regards,
Stefano
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html