Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > Before your patches, the correct management of $XDG_CONFIG_HOME to > override $HOME/.config/git/ was untested (which is unfortunate, indeed), > but after your patch serie, the fact that the default is > $HOME/.config/git/ is untested, which IMHO is even worse. > > Unsetting XDG_CONFIG_HOME and adding one test like this would be better > IMHO. Absolutely. We would want to make sure that the new code does not interfere with established uses when the user does not ask for the new feature (i.e. XDG not set), and also make sure it does what it was meant to do when the feature is called for (i.e. XDG set). It might be true that the set of tests in the series did not test the full spectrum of the latter, but then we would want to see the gap filled by adding missing tests, not by converting tests for former into the ones that test for the latter. Even with the patch below there may be other gaps in the test. For example, core.excludesfile and core.attributesfile must default to the XDG location when they exist, whether these variables are set; we may want to make sure that is not broken in the future. Michael, could you change the direction of the patch and look into filling such gaps? Thanks. > diff --git a/t/t1306-xdg-files.sh b/t/t1306-xdg-files.sh > index 3c75c3f..f1ea9f1 100755 > --- a/t/t1306-xdg-files.sh > +++ b/t/t1306-xdg-files.sh > @@ -38,6 +38,19 @@ test_expect_success 'read with --get: xdg file exists and ~/.gitconfig doesn'\'' > test_cmp expected actual > ' > > +test_expect_success '"$XDG_CONFIG_HOME overrides $HOME/.config/git' ' > + mkdir -p "$HOME"/xdg/git/ && > + echo "[user]" >"$HOME"/xdg/git/config && > + echo " name = in_xdg" >>"$HOME"/xdg/git/config && > + echo in_xdg >expected && > + ( > + XDG_CONFIG_HOME="$HOME"/xdg/ && > + export XDG_CONFIG_HOME && > + git config --get-all user.name >actual > + ) && > + test_cmp expected actual > +' > + > > test_expect_success 'read with --get: xdg file exists and ~/.gitconfig exists' ' > >.gitconfig && -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html