On 14.07.12 19:52, Michael J Gruber wrote: > t3910 is skipped for most users because it requires a filesystem which > does automatic conversion between different utf-8 types. Currently, this > results in a skipped test with "no reason given". > > Use the skip_all mechanism from our test suite so that a reason for > skipping the test is given to the user. > > Signed-off-by: Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> > --- > Alternatively, we could set a prerequisite and mark all tests with that. Since > it's either or for the whole test skip_all seems more appropriate. In that > case, we can also flatten the else branch, of course. The current patch is > minimally invasive, though. Good point, thanks. If we spin that idea further, we could move the whole t3910 into t0050. That would be nice for all non Mac OS X users in a way that we save CPU time. We already detect unicode corruption in t0050. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html