On 07/12/2012 12:12 AM, Alexander Strasser wrote: > The nested quoting is not needed in this cases, thus the previous > version did work just fine. Never the less the usage is misleading, > so just achieve nested quoting by using double quotes instead. Lower > the probability of breakage in the future and make the code easier > to read. Hi, I have some spelling corrections (minor, but since you intend to re-roll anyway, I'll post them), and one more thing which could be corrected (below). 3/6: s/Never the less/Nevertheless/ 4/6: s/masquerading/masking/ (masquerade means to "mask oneself") > if git apply --stat --summary broken 2>detected > then > echo unhappy - should have detected an error > @@ -79,7 +79,7 @@ test_expect_success 'apply detecting corrupt patch correctly' ' > ' > > test_expect_success 'apply detecting corrupt patch correctly' ' > - git diff --binary | sed -e 's/-CIT/xCIT/' >broken && > + git diff --binary | sed -e "s/-CIT/xCIT/" >broken && > if git apply --stat --summary broken 2>detected > then > echo unhappy - should have detected an error I think this can be changed to: test_must_fail git apply --stat --summary broken 2>detected - Zbyszek -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html