On Tue, 2012-07-10 at 10:40 -0700, Junio C Hamano wrote: > Carlos Martín Nieto <cmn@xxxxxxxx> writes: > > > This interface is error prone, and a better one (--set-upstream-to) > > exists. Suggest how to fix a --set-upstream invocation in case the > > user only gives one argument, which makes it likely that he meant to > > do the opposite, like with > > > > git branch --set-upstream origin/master > > > > when they meant one of > > > > git branch --set-upstream origin/master master > > git branch --set-upstream-to origin/master > > > > Signed-off-by: Carlos Martín Nieto <cmn@xxxxxxxx> > > The new code does not seem to depend on the value of "track" (which > is set by either -t or --set-upstream) in any way. Shouldn't it be > done only when it is set to track-override? Yes, yes it should. > > Doesn't "git branch [-f] frotz" without any other argument trigger > the warning? It does. Oops. Fixed. cmn -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html