Jeff King <peff@xxxxxxxx> writes:
> I'm tempting by the patch below, which would remove only the
> syntactically significant meta-characters ("\n", "<", and ">"), as well
> as trimming any stray whitespace at the edges. The problem is that we
> don't really have a clue how many people were relying on this trimming
> to clean up their names or emails, so there may be regressions for other
> people.
What do you exactly mean by "syntactically significant"? In other
words, "whose syntax"?
The code with the patch will leave "." out of the crud, so with
spearce:*:1000:1000:Shawn O. Pearce:/home/spearce:/bin/sh
we would get:
From: Shawn O. Pearce <spearce@xxxxxxxxxxx>
without dropping the "." in the name. Your MTA would likely to
reject it.
I think that quoting "syntactically significant meta-characters" in
the context of e-mail headers is a job for the MSA, and the human
readable names in GIT_AUTHOR_NAME should allow any reasonable
character. And I agree that it is a sane definition of "reasonable"
to exclude "\n", "<", and ">" (and nothing else), as they are the
only "syntactically significant" in the context of commit object
header.
The patch goes in the right direction in that sense, but you need to
make sure that git-send-email and git-imap-send (the only two MSA we
ship) do the right thing when fed names with ".", dq, etc. first.
> diff --git a/ident.c b/ident.c
> index 443c075..4552f8d 100644
> --- a/ident.c
> +++ b/ident.c
> @@ -127,15 +127,8 @@ const char *ident_default_date(void)
> static int crud(unsigned char c)
> {
> return c <= 32 ||
> - c == '.' ||
> - c == ',' ||
> - c == ':' ||
> - c == ';' ||
> c == '<' ||
> - c == '>' ||
> - c == '"' ||
> - c == '\\' ||
> - c == '\'';
> + c == '>';
> }
>
> /*
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html