Jeff King <peff@xxxxxxxx> writes:
> > /* Check that we have a git documentation directory. */
> > - if (stat(mkpath("%s/git.html", html_path), &st)
> > - || !S_ISREG(st.st_mode))
> > - die(_("'%s': not a documentation directory."), html_path);
> > + if (prefixcmp(html_path, "http:")) {
> > + if (stat(mkpath("%s/git.html", html_path), &st)
> > + || !S_ISREG(st.st_mode))
> > + die("'%s': not a documentation directory.", html_path);
> > + }
>
> I'd rather not tie this directly to http. Is there any reason not to
> allow https, for example? Can we maybe just look for strstr("://")
> instead? That's the same magic we use to differentiate URLs from paths
> when looking for repositories.
Thanks, that's a much better heuristic! I'll use !strstr(html_path, "://")
in a re-roll. You're quite right, this ought to also allow https://, ftp://,
etc.
Best wishes,
Chris.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html