On Tue, Jun 26, 2012 at 9:56 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> writes: > >> - renamed FAKE_PREAD_NOT_THREAD_SAFE to NO_THREAD_SAFE_PREAD > > Sensible. > >> - when NO_PREAD, set NO_THREAD_SAFE_PREAD in the Makefile, rather >> than in git-compat-util.h > > I think it is a bad change. When compat/ pread gets improved to be > thread-safe, this will surely be missed. But CAN it be fixed? I don't think it could, at least not without wrapping ALL calls to functions that perform IO on file handles or file descriptors... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html