2012/6/25 Thomas Rast <trast@xxxxxxxxxxx>: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> "Thomas \"Enki\" Badie" <thomas.badie@xxxxxxxxx> writes: >> >>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable >>> unused in `diff_applies' and `patch_update_file'. > [...] >> (2) the author of the problematic commit should have been Cc'ed >> (especially when he is still an active participant on the list) >> to give him a chance to Ack it (I'm adding Thomas for this). > > Indeed, my bad. It's easy to verify from 'git show 8f0bef6' that this > was an oversight in my patch. > > Acked-by: Thomas Rast <trast@xxxxxxxxxxxxxxx> It happens to everyone^^ Thanks for your answer. Should I repost a patch V2 or it is okay like this? Thanks -- Thomas "Enki" Badie -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html