On Sun, Jun 24, 2012 at 4:38 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi, > > On Sun, 24 Jun 2012, Erik Faye-Lund wrote: > >> Without /dev/tty support, git_terminal_prompt simply ignores the >> 'echo'-parameter. On Windows we can do better by clevering up our >> getpass-implementation a bit so it can conditionally echo. >> >> While we're at it, plug a small memory-leak by returning a pointer >> to a static strbuf instead of detaching it. This is the same thing >> the /dev/tty-version of git_terminal_prompt does, and the callee >> doesn't expect to have to free it's memory. > > Looks good, please apply! Done. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html