Re: [PATCHv3 01/11] Makefile: sort LIB_H list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 20, 2012 at 01:00:01PM -0700, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > This was mostly sorted already, but put things like
> > "cache-tree.h" after "cache.h", even though "-" comes before
> > "." (at least in the C locale). This will make it easier to
> > keep the list sorted later by piping it through "sort".
> 
> I agree this would make it easier to blindly run "sort", but I think
> the result hurts scannability.  Is it a good change?

I don't personally see a difference, but if you do, I don't care that
much about this patch. The main motive was that the next patch involved
adding 10 new entries, and I didn't want to have to insert them
manually into the correct sorting spots.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]