On Wed, Jun 20, 2012 at 02:30:40PM -0500, Jonathan Nieder wrote: > Jeff King wrote: > > > Here's an updated series that drops these lines and I hope will address > > the commit message issues you brought up: > > > > [01/11]: Makefile: sort LIB_H list > > [02/11]: Makefile: fold MISC_H into LIB_H > > Please no. Progress would be teaching the remaining compilers to > autocompute header dependencies so there would be no need to maintain > a master header list at all. I would understand if the headers had > been falling out of date and this were a way of saying "we give up", > but given that that is not happening, why would this change be a good > thing? Did you read the argument in patch 2? They are almost certainly not helping anyone, anyway. Forward progress would be to split all of LIB_H out into specific targets. But keeping that up to date manually is insanity, so we have this silly half-hearted attempt. I would much rather "include header-deps.mk", and then periodically rebuild and commit it using "gcc -M" (and cleaning up and canonicalizing the result) for the benefit of those without access to a compiler that can do header dependencies. In an ideal world, all compilers could do it, but I am not volunteering to patch MSVC. ;) > My comments were only about explaining what I found hard to understand > in the commit message. The patch was good. Please don't retaliate this > way. :) :) The revised commit message in patch 4 should make sense with or without these patches, so it really is a separate issue. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html