Re: [PATCH 0/9] Extending the shelf life of "git describe" output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:

> Two random thoughts:
>
> * The commit_only flag is only one thing you may "know" about the
>   parsing, as you state above.  E.g., we may know the distance from a
>   certain tag.  Given this, wouldn't it be cleaner to patch a struct
>   things_we_know into the call chain instead of only a flag?
>
> * The treeish:path syntax also "knows" that the left side must be or
>   peel to a tree, so it makes no sense to go looking for a blob.

Both good.  I take it to mean that we found a volunteer to take the
ownership of the second idea to build on top of the series ;-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]