Re: [PATCH] t: Replace 'perl' by $PERL_PATH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Torsten Bögershausen <tboegi@xxxxxx> writes:

>> PERL_PATH should be exported from test-lib.sh; we dot-source
>> GIT-BUILD-OPTIONS to get its value, but it is not propagated to the
>
> Thanks, that works for me.
> Do you squeeze some like that onto pu?
>
> @@ -493,6 +493,7 @@ GIT_ATTR_NOSYSTEM=1
>  export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG_NOSYSTEM GIT_ATTR_NOSYSTEM
>  
>  . "$GIT_BUILD_DIR"/GIT-BUILD-OPTIONS
> +export PERL_PATH

Not on 'pu'; any fix should go on top of vr/use-our-perl-in-tests
topic that ends at b493e6b (t/README: add a bit more Don'ts,
2012-06-12).

I see other uses of bare "perl" that the patch forgot to convert,
and the worst part is that one of these uses of bare "perl" appears
in test-lib.sh _before_ it dot-sources GIT-BUILD-OPTIONS to pick up
the correct version of Perl, so the above single liner cannot be the
whole fix.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]