SungHyun Nam wrote:
> If I run it on CYGWIN, there's an error msg:
>
> * FAIL 39: rename section
> git-repo-config --rename-section branch.eins branch.zwei
> * FAIL 40: rename succeeded
> diff -u expect .git/config
With a patch below, the problem gone.
BTW, there's a leak for 'config_filename' in
git_config_rename_section().
Thanks,
namsh
diff --git a/config.c b/config.c
index 663993f..a23ac47 100644
--- a/config.c
+++ b/config.c
@@ -806,6 +806,7 @@ int git_config_rename_section(const char *old_name,
const char *new_name)
}
write(out_fd, buf, strlen(buf));
}
+ fclose(config_file);
if (close(out_fd) || commit_lock_file(lock) < 0)
return error("Cannot commit config file!");
return ret;
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html