On Thu, Jun 14, 2012 at 10:23:37PM +0200, Luka Perkov wrote: > It was left out from commit 1088261f6fc90324014b5306cca4171987da85ce This commit message left me scratching my head. Did we get rid of http-fetch? If not, then don't we still need cmd_http_fetch? Or did we just make it not a builtin, in which case we wouldn't be getting rid of cmd_http_fetch, but rather converting it to main? Reading the 1088261, I find the answer: we did make it not a builtin, and it was indeed converted into "main". But its _declaration_ hung around. So maybe a better commit message would be: Subject: builtin.h: drop cmd_http_fetch declaration This was converted from a builtin into a stand-alone program by 1088261f6fc90324014b5306cca4171987da85ce, but that commit forgot to drop the declaration. Other than that, the patch looks obviously correct. -Peff PS There seem to be some other similar declarations: at least cmd_upload_tar and cmd_pickaxe. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html