Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > On Wed, Jun 13, 2012 at 10:21:04AM -0700, Junio C Hamano wrote: >> René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: >>> Am 12.06.2012 23:00, schrieb Jonathan Nieder: > >>>> Oh, hold on a second. Won't this get confused by >>>> >>>> ssh://[::1]/foo/bar/baz:80/qux > [...] >>> It shouldn't, because the host part is NUL-terminated before >>> get_port() is called. Let's see (with the patch): > [...] >> Yeah, I was wondering how that would get confused myself. Jonathan, >> ack again? > > Yeah. I had missed that when proto == PROTO_SSH that means the proto > != PROTO_LOCAL branch has been taken and the port is NUL-terminated. > > So > > Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > > It seems like a good fix given the current code structure. Sorry for > the false alarm. Thanks. By the way, it seems that Debian/Ubuntu are still carrying a bit more changes and rewrites in the connection code as local patches. Mind upstreaming them for the next cycle? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html