Simon Cathebras <simon.cathebras@xxxxxxxxxxxxxxx> writes:
> +# Check the preconditions to run git-remote-mediawiki's tests
> +test_check_precond () {
This is a very generic name (with risk of name clash in future versions
of test-lib.sh). This checks the git-mediawiki preconditions, so how
about test_check_wiki_precond?
> + if ! test_have_prereq PERL
> + then
> + skip_all='skipping gateway git-mw tests, perl not available'
> + test_done
> + fi
> +
> + if [ ! -f $GIT_BUILD_DIR/git-remote-mediawiki ];
"" around $GIT_BUILD_DIR
But why $GIT_BUILD_DIR ? git-remote-mediawiki usually doesn't go there,
it is either as source in contrib/, or installed in the $PATH.
> + then
> + skip_all='skipping gateway git-mw tests, no remote mediawiki for git found' \
> + 'please try: cp git/contrib/mw-to-git/git-remote-mediawiki git/'
Don't you have a "make install" target for that now?
+ $CURR_DIR/test-gitmw.pl getallpagename
Here and elsewhere, "" around "$CURR_DIR"
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html