On Tue, Jun 12, 2012 at 04:31:33PM +0200, Matthieu Moy wrote: > Javier.Roucher-Iglesias@xxxxxxxxxxxxxxx writes: > > > +git credential <fill|approve|reject> > > You didn't take Jeff's suggestions into account: > > http://thread.gmane.org/gmane.comp.version-control.git/199552/focus=199591 > > It's clearly too late to implement the whole suggested API, but I do > like the suggestion of allowing either a URL as argument or individual > fields on stdin, or both combined, by using the --stdin argument. > > To allow further patches to implement this without breaking backward > compatibility, your implementation could require the use of --stdin on > the command-line. Actually, after further discussion, I think that --stdin is unnecessary. If you are providing a URL, you should always provide it via stdin because of the password-disclosure issue. It's tempting to provide a command-line alternative because it's easier, but I think it would just encourage lazy developers to do the wrong thing. I do still think respecting "url=" when reading a credential makes sense, but that is easy to add later. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html