Re: [PATCHv3 4/6] Tests for git-remote-mediawiki pull

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/6/11  <konglu@xxxxxxxxxxxxxxx>:
>
> Simon Cathebras <simon.cathebras@xxxxxxxxxxxxxxx> a écrit :
>
>
>> +test_expect_success 'Git pull works after adding a new wiki page' "
>> +        wiki_reset &&
>> +       cd $TRASH_DIR &&
>> +       rm -rf mw_dir &&
>> +       rm -rf ref_page &&
>> +
>> +        git clone mediawiki::http://$SERVER_ADDR/$WIKI_DIR_NAME mw_dir &&
>> +        wiki_editpage Foo \"page created after the git clone\" false &&
>> +
>> +        cd mw_dir &&
>> +        git pull &&
>> +        cd .. &&
>> +
>> +        rm -rf ref_page &&
>> +        wiki_getallpage ref_page &&
>> +        test_diff_directories mw_dir ref_page &&
>> +        rm -rf ref_page &&
>> +        rm -rf mw_dir
>> +"
>
>
> Why are there dquotes here (and all the following tests) ? You used
> simple quote in t9360.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

We corrected this to use simple quotes in all our tests; originally we
used double quotes because of $ in the scripts, now we're escaping
them.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]