2012/6/11 Pavel Volek <Pavel.Volek@xxxxxxxxxxxxxxx>: > +sub get_mw_all_pages { > + my $pages = shift; > + # No user-provided list, get the list of pages from the API. > + my $mw_pages = $mediawiki->list({ > + action => 'query', > + list => 'allpages', > + aplimit => 500 > + }); Indentation should be 8 columns wide. > + if ($import_media) { > + # Attach list of all pages for meadia files from the API, me*dia > + > + # Get pages of related media files. This comment seems to be paraphrasing the line below, could be removed maybe. > + if ($import_media) { > + get_mw_pages_for_linked_mediafiles(\@tracked_pages, \%{$pages}); > + } > +} Not much to say on this patch, as this is basically splitting existing code. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html