On Mon, Jun 11, 2012 at 07:51:47PM +0200, Matthieu Moy wrote: > It was unclear whether the field was to be specified by the user of the > API. > > Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> > --- > > It is correct that the C API asks helpers that the user configured, > > but I think it is common across three API functions, not limited to > > credential_fill(). credential_apply_config() is called from approve > > and reject, too. > > Ah, right, so compared to v1, we can move the sentence to the > description of the "helpers" field, like this: I think this is OK. Technically it loads other matching config, as well (filling in default username fields and respecting useHttpPath). I don't know if it is worth mentioning them, too. > diff --git a/Documentation/technical/api-credentials.txt b/Documentation/technical/api-credentials.txt > index 21ca6a2..48f51ed 100644 > --- a/Documentation/technical/api-credentials.txt > +++ b/Documentation/technical/api-credentials.txt > @@ -21,7 +21,9 @@ Data Structures > The `helpers` member of the struct is a `string_list` of helpers. Each > string specifies an external helper which will be run, in order, to > either acquire or store credentials. See the section on credential > -helpers below. > +helpers below. This list is filled-in by the API functions > +according to the corresponding configuration variables before > +consulting helpers. You might want to say something like "...and therefore there is usually no need for a caller to modify the helpers field at all". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html