Erik Faye-Lund <kusmabite@xxxxxxxxx> writes: > The awkward thing about doing this, is that the memory allocated by > the strbuf cannot be reclaimed if you go with this. A pointer that has > been adjusted (like cleanup_path can do) cannot be successfully fed to > free. Yeah, I wouldn't recommend doing that. Either path = strbuf_detach(&sb, NULL); retval = xstrdup(cleanup_path(path)); free(path); return retval; or path = xstrdup(cleanup_path(sb.buf)); strbuf_release(&sb); return path; would be more sensible. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html