Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Jonathan Nieder wrote: >> Matthieu Moy wrote: >>> Junio C Hamano <gitster@xxxxxxxxx> writes: > >>>> Does "git credential" need to have a git repository (i.e. run in a >>>> git repository or in a working tree that is controlled by one)? >>> >>> It shouldn't (hence, should use RUN_SETUP_GENTLY). >> >> Rather, that means it should use 0: >> >> { "credential", cmd_credential }, > > ... and it turns out I'm talking nonsense. RUN_SETUP_GENTLY would > be a sensible choice indeed, to allow the command to discover the > current repository and read .git/config from there indeed. Yeah, I think "it is OK to be called outside a repository, but if inside we read and honor the configuration" is a sensible behaviour for this command. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html